dev: jsonschema support for revive comment directives #5448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
changed the title
alexandear
reviewed
Feb 19, 2025
alexandear
reviewed
Feb 19, 2025
Add dot at the end of descriptions Co-authored-by: Oleksandr Redko <[email protected]>
urgas9
commented
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling
config verifyby default in golangci-lint-action v6.5.0 we noticed a discrepancy between a working configuration of revive linter, supporting comment directives, and JSON schema complaining thatdirectivesfield is not allowed. This PR aims to update the JSON schema and adds an example of the directives setup.Thanks, @ldez for enabling config verify by default which ensures us to keep jsonschema in sync with the actual config file. 🤟